View Issue Details

IDProjectCategoryView StatusLast Update
0009102Multi Theft Auto : San AndreasClientpublic2018-02-21 00:23
ReporterStifflersMomAssigned Toqaisjp 
PrioritynormalSeveritytrivialReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version1.5.3 
Summary0009102: setTrainPosition issues ( 1.6 )
Description

I found the following issues while testing some train functions:

  1. setTrainPosition server and client side returns true, if you set the position of a derailed train.
  2. setTrainPosition server side returns true for any vehicle.
  3. If you use a large number for the track position client or server side, the client freezes.
Steps To Reproduce

Example for the client freeze:
I get a trolly (model 449), then:
setTrainPosition(getPedOccupiedVehicle(getPlayerFromName("StifflersMom")),10e100)

The client freezes with high cpu usage.

TagsNo tags attached.

Activities

qaisjp

2016-02-16 06:15

administrator   ~~0024417

  1. https://github.com/multitheftauto/mtasa-blue/commit/81022fcc703602572255828db55d3afde62a3610
  2. https://github.com/multitheftauto/mtasa-blue/commit/08be079fe8998e22dc13b3d9f5c0c3259758f120

qaisjp

2016-06-19 01:06

administrator   ~~0024826

Last edited: 2016-07-12 02:52

View 2 revisions

I'm not quite sure how to deal with #3. If I recall correctly (I remember testing this at the time I wrote the above commits) track positions wrap over, and this is handled by GTA.

(About wrapping: say a track ran from 0 to 200; I think position 350 would send the train to position "150")

You could just limit the track positions to reasonable values (say ±5000) but that's hacky.

qaisjp

2016-07-31 04:37

administrator   ~~0024997

  1. https://github.com/multitheftauto/mtasa-blue/commit/187b2f852ccbddab4395303f9dba3a03adf0b416

Issue History

Date Modified Username Field Change