View Issue Details

IDProjectCategoryView StatusLast Update
0009507Multi Theft Auto : San AndreasClientpublic2017-06-28 21:07
ReporterqaisjpAssigned Toqaisjp 
PrioritynormalSeverityminorReproducibilityalways
Status feedbackResolutionreopened 
Product Version1.5.3 
Target Version1.5.4Fixed in Version1.5.4 
Summary0009507: OOP getVehicleComponentRotation (and related functions) should return/accept vectors
Description

https://forum.mtasa.com/topic/90868-matrices-for-vehicle-components-please/

TagsNo tags attached.

Users sponsoring this issue
Sponsors List Total Sponsorship = EUR 1

2017-06-26 14:56: DrCrazy (EUR 1)
Users sponsoring this issue (Total Sponsorship = EUR 1)

Activities

qaisjp

2017-06-19 16:59

administrator   ~~0026033

Done! GitHub, buildinfo

DrCrazy

2017-06-26 14:56

viewer   ~~0026040

By returning vectors you broke backward compatibility with the old code. Now code like local x, y, z = vehicle:getComponentPosition(name) doesn't work and old scripts that used OOP are broken.

https://github.com/multitheftauto/mtasa-blue/commit/ee0858eb39bc127f82c6c29a742e7956accd8c0f#diff-a81378bfa4d044cef80737c99a81400aR3090

qaisjp

2017-06-28 21:07

administrator   ~~0026045

@DrCrazy: I recommend that you fix your incorrect code to use getVehicleComponentPosition, you shouldn't expect three arguments as coordinates from OOP functions. Next time please report the inconsistency.

reverted in https://github.com/multitheftauto/mtasa-blue/commit/b47310fe5b99ed0405fd5e9d7a06b3e7095462b3

Issue History

Date Modified Username Field Change