View Issue Details

IDProjectCategoryView StatusLast Update
0005050Multi Theft Auto : San AndreasScriptingpublic2009-10-24 21:29
ReporterrobholAssigned Toccw 
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Product Version1.0.1 
Target Version1.0.2Fixed in Version1.0.2 
Summary0005050: Add version parameter to onPlayerConnect
Description

If this trend of backwards-compatible versions like 1.0.1 and 1.0.2 to 1.0 etc. will continue, it might be worth adding a version parameter to the onPlayerConnect event so that servers can control which versions should be allowed in the server.

Having it in the onPlayerConnect event is WAY smoother than making it check post-join and then kick the player, as this creates unnecessary delay.

TagsNo tags attached.

Activities

Talidan

2009-10-10 22:34

administrator   ~~0010673

Last edited: 2009-10-10 22:34

I would think a getPlayerVersion scripting function is more sensible

robhol

2009-10-10 22:35

reporter   ~~0010674

Don't people read descriptions here?

"Having it in the onPlayerConnect event is WAY smoother than making it check post-join and then kick the player, as this creates unnecessary delay."

subenji99

2009-10-11 00:07

viewer   ~~0010675

Seconded.

I'm sure it's really an issue for people to wait and download resources only to be kicked afterwards for having an old version.
Another possible option is to get a client's version from a serverside function.

robhol

2009-10-11 00:09

reporter   ~~0010676

Last edited: 2009-10-11 00:09

AND in that case, giving some kind of access to the player with the event. The source for the onPlayerConnect event is apparently the root element, and I don't even think the player element is created at this point.

ccw

2009-10-18 06:46

administrator   ~~0010711

Fixed in 1.0.2-rc-10

http://github.com/multitheftauto/multitheftauto/commit/f5719633d55a212238d6b8bb772570b3fcd58c3b

Issue History

Date Modified Username Field Change