View Issue Details

IDProjectCategoryView StatusLast Update
0004769Multi Theft Auto : San AndreasGeneralpublic2009-08-10 19:54
ReporterrobholAssigned ToArc 
PriorityhighSeveritymajorReproducibilityN/A
Status resolvedResolutionfixed 
Product Version 
Target Version1.0Fixed in Version1.0 
Summary0004769: Consider reverting r1389 (Fixed #3994: Radio titles do not always show)
Description

iJs meant from the start that it was unnecessary. The bug it was supposedly "fixing" (ie. hacking around) still happens.

It also had other side effects like the radio switch event being removed, not being able to turn the radio off in both "ends" of the radio list like before.

Radio on foot (while admittedly not a hugely important feature) was also a nice thing to have, but doesn't work any more.

Since this revision not only did its job exceptionally poorly, but also had a lot of negative side effects without many (if any) redeeming qualities, I vote to revert it.

TagsNo tags attached.

Relationships

related to 0003994 resolvedZ_ReC Radio titles do not always show. 
related to 0004212 closedCazomino05 Radio music skipping when browsing between different channels 

Activities

Jax

2009-08-07 21:23

administrator   ~~0010155

Why weren't these issues added to mantis so they could be fixed without using the revert-stick? I agree with removing this from 1.0, but leave it in the trunk.

"The bug it was supposedly "fixing" (ie. hacking around) still happens."
This code is an example of the complete opposite to 'hacking around', it disables GTA's function and adds it to MTA, which gives us complete control.

Arc

2009-08-07 21:41

administrator   ~~0010157

Actually it was hacking around, you were literally going around the actual problem by reimplementing the code... And apparently this reimplementation didn't fix the problem it was supposed to either. So you may as well find the actual problem in the original SA code.

IJs

2009-08-07 21:41

administrator   ~~0010158

Last edited: 2009-08-07 21:43

I'm not sure what to do with this. The best option may very well be leaving this in the trunk and opening up separate issues underneath this one.. if we choose to use the reimplementation rather than the direct fix.

Jax

2009-08-07 21:51

administrator   ~~0010159

I wouldn't call rewriting code 'hacking' but to each their own..
Leave this in the trunk and Il look at the separate issues, they all seem pretty minor.
It's easier for us to fix MTA code than to go looking through assembly.

Jax

2009-08-10 19:42

administrator   ~~0010178

Ive re-added this, including the radio-switch event, a fix for #4212 and made it more like single player.

Issue History

Date Modified Username Field Change